Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the imported modules. #2633

Merged
merged 2 commits into from
May 31, 2024

Conversation

airvzxf
Copy link
Contributor

@airvzxf airvzxf commented May 29, 2024

📝 Description

Type: 🪲 bugfix

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Some imported modules for Monte Carlo weren't refactored.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

Screenshot when the command started.
Screenshot_2024-05-29_12-21-22

Screenshot when the command finished.
Screenshot_2024-05-29_12-21-36

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe): Local environment and ran the benchmarks without fatal failure.
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.
@andrewfullard
@atharva-2001
@officialasishkumar

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. It will also be fixed in my MC refactor PR but that may take some more time!

@tardis-bot
Copy link
Contributor

tardis-bot commented May 29, 2024

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (2ad5228) and the latest commit (05548a5).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.
Significantly changed benchmarks:

· No results found

All benchmarks:

· No results found

@jvshields jvshields merged commit 65e2f1c into tardis-sn:master May 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants