Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Generation Tests #2631

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 🚦 testing

The generation tests add a huge chunk of time to the test workflow. We'd want the test workflow to finish earlier.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (e12ccf3) to head (438c1fc).
Report is 5 commits behind head on master.

Current head 438c1fc differs from pull request most recent head 2a77edc

Please upload reports for the commit 2a77edc to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2631   +/-   ##
=======================================
  Coverage   67.76%   67.76%           
=======================================
  Files         171      171           
  Lines       14411    14411           
=======================================
  Hits         9765     9765           
  Misses       4646     4646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@atharva-2001 atharva-2001 force-pushed the move_generation_tests branch from 438c1fc to b1167a6 Compare May 28, 2024 12:36
@atharva-2001 atharva-2001 added the run-generation-tests Run refdata generation tests on pull requests label May 29, 2024
@atharva-2001 atharva-2001 marked this pull request as ready for review May 29, 2024 09:17
andrewfullard
andrewfullard previously approved these changes May 29, 2024
jvshields
jvshields previously approved these changes Jun 3, 2024
@atharva-2001 atharva-2001 dismissed stale reviews from jvshields and andrewfullard via 2a77edc June 3, 2024 14:38
@DeerWhale DeerWhale enabled auto-merge (squash) June 3, 2024 14:48
@DeerWhale DeerWhale merged commit 1cc653c into tardis-sn:master Jun 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD run-generation-tests Run refdata generation tests on pull requests work in progress 🚧
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants