Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating github changes command in post release workflow (changelog fix) #2629

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

KasukabeDefenceForce
Copy link
Contributor

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Fixing the post release workflow by updating the github changes command.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@atharva-2001 atharva-2001 changed the title Updating github changes command in post release workflow Updating github changes command in post release workflow (changelog fix) Jun 20, 2024
Fixing template for changelog

Removing personal token

removing PAT
@KasukabeDefenceForce KasukabeDefenceForce marked this pull request as ready for review June 24, 2024 13:43
@andrewfullard
Copy link
Contributor

Can you provide an example changelog entry?

@KasukabeDefenceForce
Copy link
Contributor Author

Can you provide an example changelog entry?

https://github.com/KasukabeDefenceForce/tardis/actions/runs/9645564434

@andrewfullard
Copy link
Contributor

Can you provide an example changelog entry?

https://github.com/KasukabeDefenceForce/tardis/actions/runs/9645564434

Looks good, I assume the missing version and incorrect date is because it's not attached to an actual release?

@KasukabeDefenceForce
Copy link
Contributor Author

Can you provide an example changelog entry?

https://github.com/KasukabeDefenceForce/tardis/actions/runs/9645564434

Looks good, I assume the missing version and incorrect date is because it's not attached to an actual release?

Yes

@andrewfullard andrewfullard enabled auto-merge (squash) June 24, 2024 14:33
@wkerzendorf wkerzendorf self-requested a review June 24, 2024 14:33
@andrewfullard andrewfullard merged commit 0df98ce into tardis-sn:master Jun 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants