Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2564 by bringing back the image from a previous commit #2619

Conversation

Sumit112192
Copy link
Contributor

📝 Description

Type: : 📝 documentation

In some previous commits, the image packet_diagram.jpg was not stored in TARDIS but instead uploaded via Jupyter lab in an ipynb file. In commit 846ef7c that was mistakenly deleted.

I went back to the commit a8a9540 and downloaded the original image. I stored it in docs/io/images and linked it in the ipynb file.

Fixes #2564

📌 Resources

Current Output:
image

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (Documentation Changes)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.
@andrewfullard @erinvisser

@wkerzendorf wkerzendorf self-requested a review May 15, 2024 13:36
@andrewfullard andrewfullard enabled auto-merge (squash) May 15, 2024 13:39
@andrewfullard andrewfullard disabled auto-merge May 15, 2024 13:43
@andrewfullard andrewfullard merged commit 95dadcf into tardis-sn:master May 15, 2024
11 of 13 checks passed
@Sumit112192 Sumit112192 deleted the packet_diagram_image_not_displaying_fix branch May 22, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - Diagram not displaying in Montecarlo Packet Visualization
3 participants