Fixing build docs yaml to detect branches on forks #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfullard
requested changes
May 14, 2024
.github/workflows/build-docs.yml
Outdated
| @@ -48,7 +48,7 @@ jobs: | |||
| uses: actions/checkout@v4 | |||
| with: | |||
| fetch-depth: 0 | |||
| ref: ${{ github.event.pull_request.head.ref }} | |||
| ref: ${{ github.sha }} | |||
There was a problem hiding this comment.
ref: ${{ github.event.pull_request.head.sha }} is what was used in the previous docs workflow. Please use that instead.
There was a problem hiding this comment.
I have updated the ref.
andrewfullard
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfixThe build docs yaml currently clones only the main repository but we are updating it to work on branches on forks.
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel