Reference Data Generation Fixes

[atharva-2001]

📝 Description

Type: 🪲 bugfix 🚦 testing |

• change hdf properties for simulation.transport

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

• Testing pipeline
• Other method (describe)
• My changes can't be tested (explain why)

☑️ Checklist

• I requested two reviewers for this pull request
• I updated the documentation according to my changes
• I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.17%. Comparing base (1718002) to head (43cfa63).
Report is 6 commits behind head on master.

❗ Current head 43cfa63 differs from pull request most recent head 9dd7c85. Consider uploading reports for the commit 9dd7c85 to get more accurate results

Files	Patch %	Lines
tardis/simulation/tests/test_simulation.py	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2562      +/-   ##
==========================================
- Coverage   68.18%   68.17%   -0.01%     
==========================================
  Files         168      168              
  Lines       14219    14223       +4     
==========================================
+ Hits         9695     9697       +2     
- Misses       4524     4526       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[atharva-2001]

/compare-refdata

[atharva-2001]

/update-refdata

[tardis-bot]

*beep* *bop*

Hi, human.

The update-refdata workflow has failed ❌

Click here to see the build log.

[atharva-2001]

/update-refdata

[andrewfullard]

Can you explain the test failures?

[atharva-2001]

It's because the reference data needs to be updated. The update refdata workflow will not work on this PR because the YAML file on the master does not have steps which add the regression tests settings. This PR fixes that. Once this PR is in, we can either run the workflow or I can update the repo and the tests should work then.

[andrewfullard]

This is simply a change in where the reference data are located in the HDF file, and not a change in the numbers, right?

[atharva-2001]

This is simply a change in where the reference data are located in the HDF file, and not a change in the numbers, right?

No, I don't think there is a change in numbers.

[andrewfullard]

I would like to get this merged ASAP, but it would be best after #2119 because that changes quite a few files.

[andrewfullard]

After rebasing #2119 it actually changes only a few files (good!) so this should be mergeable now?