Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiindex dataframe #2552

Merged
merged 9 commits into from
Apr 2, 2024
Merged

Multiindex dataframe #2552

merged 9 commits into from
Apr 2, 2024

Conversation

Knights-Templars
Copy link
Member

@Knights-Templars Knights-Templars commented Mar 18, 2024 •
edited
Loading

📝 Description

Type: | 🚀 feature | 🎢 infrastructure

Distribution of decay energy based on the decay channel.

🚦 Testing

How did you test these changes?

  • Testing in progress

☑️ Checklist

  • I requested two reviewers for this pull request

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@Knights-Templars Knights-Templars marked this pull request as draft March 18, 2024 01:35
@Knights-Templars Knights-Templars requested review from andrewfullard and wkerzendorf and removed request for andrewfullard March 18, 2024 01:36
wkerzendorf
wkerzendorf reviewed Mar 22, 2024
View reviewed changes
tardis/energy_input/gamma_ray_channel.py Outdated
isotope_decay_df["decay_mode"] = isotope_decay_df["decay_mode"].astype(
"category"
)
isotope_decay_df["rad_type"] = isotope_decay_df["rad_type"].astype(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using useful names the categories and make them all uppercase

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All column names are kept lower case.

@wkerzendorf
Copy link
Member

Please add a notebook for documentation.

@Knights-Templars
Copy link
Member Author

Please add a notebook for documentation.

Added notebook.

@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.88732% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.51%. Comparing base (20b2a64) to head (eb009e5).
Report is 9 commits behind head on master.

Files Patch % Lines
...dis/energy_input/tests/test_gamma_ray_transport.py 60.00% 2 Missing ⚠️
tardis/energy_input/gamma_ray_transport.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2552      +/-   ##
==========================================
- Coverage   68.17%   67.51%   -0.66%     
==========================================
  Files         166      170       +4     
  Lines       14135    14230      +95     
==========================================
- Hits         9636     9608      -28     
- Misses       4499     4622     +123

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Knights-Templars Knights-Templars marked this pull request as ready for review March 25, 2024 18:29
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

andrewfullard
andrewfullard requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close, just needs some cleanup and comment responses

tardis/energy_input/gamma_ray_channel.py Show resolved Hide resolved
tardis/energy_input/gamma_ray_channel.py Outdated Show resolved Hide resolved
tardis/energy_input/gamma_ray_channel.py Outdated Show resolved Hide resolved
tardis/energy_input/gamma_ray_channel.py Outdated Show resolved Hide resolved
tardis/energy_input/gamma_ray_channel.py Outdated Show resolved Hide resolved
tardis/energy_input/tests/test_gamma_ray_channel.py Outdated Show resolved Hide resolved
tardis/energy_input/tests/test_gamma_ray_channel.py Show resolved Hide resolved
tardis/energy_input/tests/test_gamma_ray_channel.py Outdated Show resolved Hide resolved
tardis/energy_input/tests/test_gamma_ray_channel.py Outdated Show resolved Hide resolved
tardis/energy_input/tests/test_gamma_ray_channel.py Show resolved Hide resolved
andrewfullard
andrewfullard requested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most critical remaining change is that the output dataframe is still lacking a column for energy in erg and not just keV, as we discussed. Also one small docstring change.

@Knights-Templars
Copy link
Member Author

Most critical remaining change is that the output dataframe is still lacking a column for energy in erg and not just keV, as we discussed. Also one small docstring change.

I have missed that.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@andrewfullard andrewfullard merged commit 763f571 into tardis-sn:master Apr 2, 2024
13 of 14 checks passed
@airvzxf airvzxf mentioned this pull request Apr 20, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atharva-2001 atharva-2001 atharva-2001 left review comments

@andrewfullard andrewfullard andrewfullard approved these changes

@wkerzendorf wkerzendorf Awaiting requested review from wkerzendorf

Assignees
No one assigned
Labels
build-docs nebular restructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Knights-Templars @wkerzendorf @tardis-bot @andrewfullard @atharva-2001