PR to separate main gamma ray loop #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkerzendorf
reviewed
Mar 5, 2024
| for shell in decay_energy | ||
| } | ||
|
|
||
| return fractional_decay_energy |
There was a problem hiding this comment.
that looks complex - would a dataframe be better here?
wkerzendorf
reviewed
Mar 5, 2024
wkerzendorf
reviewed
Mar 5, 2024
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ctional energy. Much Cleaner
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2529 +/- ##
==========================================
- Coverage 68.74% 68.17% -0.57%
==========================================
Files 165 166 +1
Lines 13999 14135 +136
==========================================
+ Hits 9623 9636 +13
- Misses 4376 4499 +123 ☔ View full report in Codecov by Sentry. |
|
*beep* *bop* Hi, human. The Click here to see your results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR. In this PR, we have functions calculating the distribution of packets to each isotope, fractional energy per isotope per decay chain in each shell. We also separate the main_gamma_ray_loop from the gamma_ray_transport.