Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Montecarlo configuration refactor #2525

Merged
merged 15 commits into from
Apr 19, 2024

Conversation

andrewfullard
Copy link
Contributor

Absolutely horrible refactor that converts the Montecarlo configuration globals into a jitclass

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 53.59477% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 69.12%. Comparing base (5bca272) to head (15ebac8).
Report is 5 commits behind head on master.

❗ Current head 15ebac8 differs from pull request most recent head d2f1c58. Consider uploading reports for the commit d2f1c58 to get more accurate results

Files Patch % Lines
tardis/montecarlo/montecarlo_configuration.py 50.00% 18 Missing ⚠️
.../montecarlo/estimators/radfield_estimator_calcs.py 39.28% 17 Missing ⚠️
tardis/montecarlo/montecarlo_numba/interaction.py 38.46% 8 Missing ⚠️
tardis/montecarlo/montecarlo_numba/vpacket.py 0.00% 8 Missing ⚠️
tardis/transport/r_packet_transport.py 28.57% 5 Missing ⚠️
...is/montecarlo/estimators/radfield_mc_estimators.py 42.85% 4 Missing ⚠️
tardis/montecarlo/tests/test_montecarlo.py 0.00% 3 Missing ⚠️
tardis/montecarlo/montecarlo_numba/base.py 0.00% 2 Missing ⚠️
.../montecarlo/montecarlo_numba/single_packet_loop.py 33.33% 2 Missing ⚠️
tardis/transport/frame_transformations.py 50.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2525      +/-   ##
==========================================
+ Coverage   67.51%   69.12%   +1.60%     
==========================================
  Files         170      166       -4     
  Lines       14228    13988     -240     
==========================================
+ Hits         9606     9669      +63     
+ Misses       4622     4319     -303     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tardis-bot
Copy link
Contributor

tardis-bot commented Feb 29, 2024

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (5bca272) and the latest commit (d2f1c58).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.
Significantly changed benchmarks:

· No results found

All benchmarks:

· No results found

@tardis-bot
Copy link
Contributor

tardis-bot commented Feb 29, 2024

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@andrewfullard andrewfullard marked this pull request as draft March 6, 2024 19:42
@andrewfullard andrewfullard marked this pull request as ready for review April 10, 2024 18:40
@andrewfullard andrewfullard requested a review from jvshields April 17, 2024 16:45
@andrewfullard andrewfullard merged commit e25468d into tardis-sn:master Apr 19, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants