Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if atom data download exists #2479

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

wkerzendorf
Copy link
Member

and do not redownload unless forced.

@tardis-bot
Copy link
Contributor

tardis-bot commented Nov 27, 2023

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0599113) 67.17% compared to head (b210089) 67.16%.
Report is 2 commits behind head on master.

Files Patch % Lines
tardis/io/atom_data/atom_web_download.py 14.28% 6 Missing ⚠️
tardis/io/configuration/config_internal.py 70.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2479      +/-   ##
==========================================
- Coverage   67.17%   67.16%   -0.02%     
==========================================
  Files         156      156              
  Lines       13763    13767       +4     
==========================================
+ Hits         9245     9246       +1     
- Misses       4518     4521       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this helps the docs issue

@andrewfullard andrewfullard self-requested a review November 29, 2023 21:41
@andrewfullard andrewfullard merged commit f7dd18a into tardis-sn:master Nov 29, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants