Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mamba Instead of Conda When Running Benchmarks #2455

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

atharva-2001
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🎢 infrastructure

It appears to me that it takes a long time for conda to solve the new environment, which can be done easily with Mamba. A new asv release a few months back allows mamba as a environment type. This adds that along with an action that installs mamba and asv into the environment.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Oct 26, 2023

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (799e35b) and the latest commit (ee7e251).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.
Significantly changed benchmarks:

· Benchmark list file .asv/results/benchmarks.json missing!
Use `asv run --bench just-discover` to regenerate benchmarks.json

All benchmarks:

· Benchmark list file .asv/results/benchmarks.json missing!
Use `asv run --bench just-discover` to regenerate benchmarks.json

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (799e35b) 68.72% compared to head (ee7e251) 68.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2455   +/-   ##
=======================================
  Coverage   68.72%   68.72%           
=======================================
  Files         157      157           
  Lines       13872    13872           
=======================================
  Hits         9534     9534           
  Misses       4338     4338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atharva-2001 atharva-2001 force-pushed the benchmarks_oct_23_fix branch from 00615f8 to 64a2eb4 Compare October 26, 2023 08:50
@atharva-2001
Copy link
Member Author

atharva-2001 commented Oct 26, 2023

Some of the steps are skipped. I raised a GitHub ticket about this. I would remove the last two commits if either I get a response from GitHub or I am able to resolve the issue.

@andrewfullard
Copy link
Contributor

Still seeing empty "linux-64" and "osx-64" actions in the PR checks.

@atharva-2001 atharva-2001 marked this pull request as draft November 1, 2023 13:17
@atharva-2001 atharva-2001 force-pushed the benchmarks_oct_23_fix branch from 03c4865 to ff6edb3 Compare November 1, 2023 13:18
@atharva-2001
Copy link
Member Author

atharva-2001 commented Nov 28, 2023

@atharva-2001 atharva-2001 marked this pull request as ready for review November 28, 2023 11:36
@wkerzendorf wkerzendorf merged commit b68e542 into tardis-sn:master Dec 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants