integrate radiation field #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander Grunewald <AlexanderGrunewald@users.noreply.github.com> Co-authored-by: Andreas Flörs <afloers@users.noreply.github.com> Co-authored-by: Jack O'Brien <Rodot-@users.noreply.github.com> Co-authored-by: Andrew Fullard <andrewgfullard@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2365 +/- ##
==========================================
+ Coverage 70.53% 70.57% +0.04%
==========================================
Files 138 139 +1
Lines 12866 12875 +9
==========================================
+ Hits 9075 9087 +12
+ Misses 3791 3788 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6e3ae36 to
a76c5c4
Compare
tardis/radiation_field/base.py
Outdated
| from tardis.montecarlo.montecarlo_numba.numba_interface import OpacityState | ||
|
|
||
|
|
||
| class RadiationField: |
There was a problem hiding this comment.
Do we want to be clear about this being a radiationfieldstate?
|
@andrewfullard I've included your suggestions. |
andrewfullard
previously approved these changes
Jul 25, 2023
|
Looks like |
99fd6ec to
aff650a
Compare
aff650a to
5623d24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New integration of radiation field