Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc failure after restructuring packet source seed #2336

Merged

Conversation

xansh
Copy link
Member

@xansh xansh commented Jun 20, 2023

📝 Description

Type: 🪲 bugfix | 🚦 testing

This PR fixes the lingering doc failure caused by #2329 .

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

tardis-bot commented Jun 20, 2023

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #2336 (329cfba) into master (b5738b3) will not change coverage.
The diff coverage is n/a.

❗ Current head 329cfba differs from pull request most recent head ff446c1. Consider uploading reports for the commit ff446c1 to get more accurate results

@@           Coverage Diff           @@
##           master    #2336   +/-   ##
=======================================
  Coverage   71.95%   71.95%           
=======================================
  Files         137      137           
  Lines       12517    12517           
=======================================
  Hits         9006     9006           
  Misses       3511     3511           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xansh
Copy link
Member Author

xansh commented Jun 20, 2023

beep bop

Hi, human.

The docs workflow has failed

Click here to see the build log.

This seems unrelated to my changes. @andrewfullard can you please check

@xansh xansh closed this Jun 20, 2023
@xansh xansh reopened this Jun 20, 2023
@andrewfullard andrewfullard enabled auto-merge (squash) June 21, 2023 12:52
@andrewfullard andrewfullard requested a review from Rodot- June 22, 2023 12:56
@andrewfullard andrewfullard merged commit 1e69315 into tardis-sn:master Jun 22, 2023
@xansh xansh deleted the restructure-packet-source-seed branch June 22, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants