Save LFS Objects always()
#2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfullard
approved these changes
Apr 26, 2023
Codecov Report
@@ Coverage Diff @@
## master #2284 +/- ##
==========================================
- Coverage 71.84% 71.81% -0.03%
==========================================
Files 133 135 +2
Lines 12398 12431 +33
==========================================
+ Hits 8907 8927 +20
- Misses 3491 3504 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ymatsumu
approved these changes
Apr 27, 2023
light2802
pushed a commit
to light2802/tardis
that referenced
this pull request
May 27, 2023
* set repository owner * has to be in quotes * Leave spaces before and after == * Save cache intentionally * Temporarily allow running on my fork * Add comments, try removing quotation marks in false keyword * Disable tests on forks again [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
🚦
testing| 🎢infrastructureAdd a step which saves LFS cache even if the workflow fails.
📌 Resources
Uses a fake ternary operator:
https://github.com/orgs/community/discussions/26738#discussioncomment-3253176
Save: https://github.com/actions/cache/tree/main/save
Restore: https://github.com/actions/cache/tree/main/restore
Please merge #2280 before.
🚦 Testing
How did you test these changes?
Workflow to save cache:
https://github.com/atharva-2001/tardis/actions/runs/4805192448/jobs/8551369172
Workflow to restore cache:
https://github.com/atharva-2001/tardis/actions/runs/4805192448/jobs/8551369172
☑️ Checklist
build_docslabel