Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Basic Benchmarks Using ASV #2260

Merged
merged 75 commits into from
Jun 15, 2023

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Mar 27, 2023

📝 Description

🚦 testing | 🎢 infrastructure

Basic Benchmarks using ASV. Still a work in progress.
TODO:

  • Send results of benchmarks of last 10 commits to a different repository
  • Deploy from remote repo
  • Compare master and head in PRs
  • Commit message saying if the benchmarks are faster or slower
  • Save results of all the commits
  • Not save env because it's too large
  • [ ]

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #2260 (8578620) into master (a9bde5c) will not change coverage.
The diff coverage is n/a.

❗ Current head 8578620 differs from pull request most recent head 4fff311. Consider uploading reports for the commit 4fff311 to get more accurate results

@@           Coverage Diff           @@
##           master    #2260   +/-   ##
=======================================
  Coverage   71.96%   71.96%           
=======================================
  Files         137      137           
  Lines       12514    12514           
=======================================
  Hits         9006     9006           
  Misses       3508     3508           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atharva-2001
Copy link
Member Author

@epassaro @andrewfullard is it alright to remove hdf5 library if all tests pass? I don't see it being used anywhere in the code

asv.conf.json Outdated Show resolved Hide resolved
asv.conf.json Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the CI shows a tick

@epassaro
Copy link
Member

I'm going to review this on the wekend

@wkerzendorf wkerzendorf disabled auto-merge June 15, 2023 16:13
@wkerzendorf wkerzendorf merged commit 15b5d3b into tardis-sn:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants