Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for parallel fixes for estimators #2233

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

1e9abhi1e10
Copy link
Contributor

📝 Description

Type: :| 📝 documentation

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

closes #2031

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • [ x] Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #2233 (f4f2d1e) into master (239e04b) will not change coverage.
The diff coverage is n/a.

❗ Current head f4f2d1e differs from pull request most recent head b4e7d08. Consider uploading reports for the commit b4e7d08 to get more accurate results

@@           Coverage Diff           @@
##           master    #2233   +/-   ##
=======================================
  Coverage   71.81%   71.81%           
=======================================
  Files         133      133           
  Lines       12355    12355           
=======================================
  Hits         8873     8873           
  Misses       3482     3482           
Impacted Files Coverage Δ
tardis/montecarlo/montecarlo_numba/base.py 31.93% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@1e9abhi1e10
Copy link
Contributor Author

@andrewfullard Please have a look

@andrewfullard andrewfullard requested review from Rodot- and chvogl March 6, 2023 13:49
@1e9abhi1e10
Copy link
Contributor Author

@andrewfullard please have a look

Copy link
Contributor

@Rodot- Rodot- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@andrewfullard andrewfullard merged commit 21e86c4 into tardis-sn:master Apr 3, 2023
light2802 pushed a commit to light2802/tardis that referenced this pull request May 27, 2023
* Added documentation for parallel fixes for estimators

* run black

* remove comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document parallel fixes for estimators
3 participants