Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing construction of the first guess and coefficient matrices in NLTE solver #2201
Changing construction of the first guess and coefficient matrices in NLTE solver #2201
Changes from 11 commits
91c8882
78b5c91
38f895a
82ae5c5
a63ea03
ed5184e
94645d1
7f147cb
2de10bf
2eb1e55
6112033
3ebf154
c6b7949
3957a94
14d9d20
d906658
fd1076d
8c1359d
625deed
efc91dd
7e36921
7c8869f
8b43ebb
fc31c1c
d4b1e29
409abde
88a362c
a3c1c23
a81f670
7e60181
d23aaf1
333b5ae
5705c2c
02f33c4
946d039
c370b6b
cdfe71f
0966d04
d5c980c
c7d6641
405ed75
f3a6d4c
b82b200
8333e62
af462be
5167aa8
6b086e1
4c0d3e0
993200e
8f0a341
cf805d9
2166667
259a0cc
f471a20
4b27db3
0dc7660
5130670
6770958
e481e7b
1ac0ee1
dbfc1c8
da26718
007910a
2109509
44e060f
af8ad20
74c37f3
a432a25
5f34e1f
fbab174
a0f4f0d
39751b1
51c03cb
d2e6952
7bfa59a
73193e8
913cd7f
3c2f68a
e26020a
ebb36f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed? Can you not just do an indexing operation later when you loop over the nlte_excitation_species to build the rate matrices?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of getting the rates once and just using them afterwards, to be consistent with other rates that we have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think this is unnecessarily complicated unless you have a solution for creating the collisional rate matrices that does not involve a for loop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can get rid of it and construct it "on the go" while preparing the rate matrix.