Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved helium nlte to a seperate file helium_nlte.py #2130

Merged
merged 5 commits into from
Sep 29, 2022

Conversation

sonachitchyan
Copy link
Member

@sonachitchyan sonachitchyan commented Sep 29, 2022

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

This PR moves helium_nlte to a separate file for better organizing of nlte part of the code.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@sonachitchyan sonachitchyan linked an issue Sep 29, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #2130 (e9e0ce5) into master (a12b983) will increase coverage by 0.03%.
The diff coverage is 34.37%.

@@            Coverage Diff             @@
##           master    #2130      +/-   ##
==========================================
+ Coverage   61.60%   61.63%   +0.03%     
==========================================
  Files          74       75       +1     
  Lines        8641     8649       +8     
==========================================
+ Hits         5323     5331       +8     
  Misses       3318     3318              
Impacted Files Coverage Δ
tardis/plasma/properties/nlte.py 100.00% <ø> (+59.43%) ⬆️
tardis/plasma/properties/helium_nlte.py 34.37% <34.37%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wkerzendorf wkerzendorf merged commit e3184f4 into tardis-sn:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor nlte.py and split out helium_nlte
2 participants