adding nonhomologous_grid.py #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2121 +/- ##
==========================================
- Coverage 71.81% 71.78% -0.03%
==========================================
Files 133 135 +2
Lines 12355 12388 +33
==========================================
+ Hits 8873 8893 +20
- Misses 3482 3495 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andrewfullard
requested changes
Aug 29, 2022
|
Looks good, needs tests |
andrewfullard
approved these changes
Mar 15, 2023
Rodot-
approved these changes
Apr 20, 2023
| return factor | ||
|
|
||
|
|
||
| # @njit(**njit_dict_no_parallel) |
light2802
pushed a commit
to light2802/tardis
that referenced
this pull request
May 27, 2023
* adding nonhomologous_grid.py * got rid of unnecessary comments * wiki link * returning dv/dr from velocity function * changing the name of roots to quartic_roots * corresponding change to dv/dr usage * adding tau_sobolev factor equation * renamed function velocity to velocity_dvdr * rewrote the quartic root finding * added more cases to the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfix| 🚀feature| ☣️breaking change| 🚦testing| 📝documentation| 🎢infrastructureThis PR adds nonhomologous_grid.py to montecarlo/montecarlo_numba for further use in nonhomologous expansion implementation.
Also, link issues affected by this pull request by using the keywords:
close,closes,closed,fix,fixes,fixed,resolve,resolvesorresolved.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel