-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continuing geometry restructure #2065
Merged
andrewfullard
merged 6 commits into
tardis-sn:master
from
nolanbrown01:continuing-geometry-restructure
Jun 21, 2022
Merged
Continuing geometry restructure #2065
andrewfullard
merged 6 commits into
tardis-sn:master
from
nolanbrown01:continuing-geometry-restructure
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncies were renamed.
…dependencies. Corrected a typo in a comment ("varibale" --> "variable").
Moved frame_transformations to transport from montecarlo_numba. Renamed dependencies. |
@andrewfullard do you know why there might be a conflict between those files? |
Codecov Report
@@ Coverage Diff @@
## master #2065 +/- ##
=======================================
Coverage 58.34% 58.34%
=======================================
Files 76 76
Lines 8593 8593
=======================================
Hits 5014 5014
Misses 3579 3579
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
sonachitchyan
approved these changes
Jun 21, 2022
andrewfullard
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🎢
infrastructure
Fixed a typo in a comment line (misspelling of variable). Moved r_packet_transport to folder transport, from folder montecarlo_numba. Modified dependencies.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label