Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing geometry restructure #2065

Merged

Conversation

nolanbrown01
Copy link
Contributor

@nolanbrown01 nolanbrown01 commented Jun 20, 2022

📝 Description

Type: 🎢 infrastructure

Fixed a typo in a comment line (misspelling of variable). Moved r_packet_transport to folder transport, from folder montecarlo_numba. Modified dependencies.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@nolanbrown01
Copy link
Contributor Author

Moved frame_transformations to transport from montecarlo_numba. Renamed dependencies.

@sonachitchyan
Copy link
Member

@andrewfullard do you know why there might be a conflict between those files?

@nolanbrown01 nolanbrown01 marked this pull request as ready for review June 21, 2022 16:05
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #2065 (725fbb3) into master (20cb998) will not change coverage.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##           master    #2065   +/-   ##
=======================================
  Coverage   58.34%   58.34%           
=======================================
  Files          76       76           
  Lines        8593     8593           
=======================================
  Hits         5014     5014           
  Misses       3579     3579           
Impacted Files Coverage Δ
tardis/transport/frame_transformations.py 49.01% <ø> (ø)
tardis/transport/r_packet_transport.py 20.00% <50.00%> (ø)
...lo_numba/continuum/r_packet_transport_continuum.py 15.15% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/estimators.py 41.37% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/interaction.py 28.00% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/r_packet.py 50.00% <100.00%> (ø)
.../montecarlo/montecarlo_numba/single_packet_loop.py 26.86% <100.00%> (ø)
tardis/montecarlo/montecarlo_numba/vpacket.py 21.78% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andrewfullard andrewfullard merged commit a8bad89 into tardis-sn:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants