Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOI badge to credits section #2045

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Jun 6, 2022

📝 Description

Type: 📝 documentation | 🎢 infrastructure

Added the specific DOI badge to the Credits section of the documentation, and consequently in README.rst.

📌 Resources

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

Can't be tested on CI because this change will be triggered only at post-release stage. But you can test it locally by running python ./ci-helpers/update_credits.py and then cd docs && DISABLE_NBSPHINX=1 make html. Should look like this:

image

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@epassaro epassaro requested review from andrewfullard and Rodot- June 6, 2022 17:44
@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #2045 (3bcf78a) into master (2b220af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2045   +/-   ##
=======================================
  Coverage   59.87%   59.87%           
=======================================
  Files          70       70           
  Lines        8157     8157           
=======================================
  Hits         4884     4884           
  Misses       3273     3273           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro epassaro merged commit 0aa7165 into tardis-sn:master Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants