Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-release workflow automation #2012

Merged
merged 1 commit into from
May 5, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented May 5, 2022

Description

The post-release workflow failed after the latest release, but worked after running manually. The actual cause seems to be well documented in the build log:

When the repository is checked out on a commit instead of a branch, the 'base' input must be supplied.

I have the feeling this is going to fail too when the pre-release is triggered via cron, so added the parameter there too.

Motivation and context

How has this been tested?

  • Testing pipeline
  • Other

Examples

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • None of the above

Checklist

  • I have updated the documentation according to my changes
  • I have built the documentation by applying the build_docs label to this pull request (if you don't have enough privileges a reviewer will do it for you)
  • I have requested two reviewers for this pull request

@epassaro epassaro force-pushed the ci/fix-post-release-workflow branch from c7f6df7 to 308644d Compare May 5, 2022 15:45
@epassaro epassaro force-pushed the ci/fix-post-release-workflow branch from 308644d to 3e8ddf2 Compare May 5, 2022 15:46
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #2012 (6ee60fb) into master (66eb19f) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ee60fb differs from pull request most recent head 3e8ddf2. Consider uploading reports for the commit 3e8ddf2 to get more accurate results

@@           Coverage Diff           @@
##           master    #2012   +/-   ##
=======================================
  Coverage   60.01%   60.01%           
=======================================
  Files          70       70           
  Lines        8115     8115           
=======================================
  Hits         4870     4870           
  Misses       3245     3245           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro epassaro merged commit 9976a20 into tardis-sn:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants