Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pull_request_target trigger in release workflow #2007

Merged
merged 1 commit into from
May 5, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented May 4, 2022

Description

The new release workflow is not triggered automatically after merging the changes from pre-release.

This happens because I used the wrong trigger: pull_request does not have access to the required BOT_TOKEN to make this operation.

We need to use pull_request_target for that as it was described in the GitHub Documentation.

The manual workflow_dispatch trigger seems to work just right.

Motivation and context

How has this been tested?

  • Testing pipeline
  • Other

Examples

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • None of the above

Checklist

  • I have updated the documentation according to my changes
  • I have built the documentation by applying the build_docs label to this pull request (if you don't have enough privileges a reviewer will do it for you)
  • I have requested two reviewers for this pull request

@epassaro epassaro marked this pull request as draft May 4, 2022 17:07
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2007 (fd42b3a) into master (1133636) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2007   +/-   ##
=======================================
  Coverage   59.99%   59.99%           
=======================================
  Files          70       70           
  Lines        8112     8112           
=======================================
  Hits         4867     4867           
  Misses       3245     3245           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro epassaro marked this pull request as ready for review May 4, 2022 23:06
@epassaro epassaro merged commit a727caa into tardis-sn:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants