-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs build after upgrading conda environment #1969
Fix docs build after upgrading conda environment #1969
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Codecov Report
@@ Coverage Diff @@
## master #1969 +/- ##
=======================================
Coverage 59.85% 59.85%
=======================================
Files 70 70
Lines 8080 8080
=======================================
Hits 4836 4836
Misses 3244 3244 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@wkerzendorf these two changes are enough to build docs locally: diff --git a/docs/conf.py b/docs/conf.py
index 3e0a96be7..f8f33dd46 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -28,6 +28,7 @@
import os
import sys
import datetime
+import tardis
from importlib import import_module
try:
diff --git a/docs/physics/spectrum/basic.ipynb b/docs/physics/spectrum/basic.ipynb
index 86f5e4bac..0a51ea926 100644
--- a/docs/physics/spectrum/basic.ipynb
+++ b/docs/physics/spectrum/basic.ipynb
@@ -358,7 +358,7 @@
"source": [
"emitted_luminosity_hist = u.Quantity(np.histogram(emitted_nus,\n",
" weights=emitted_luminosities,\n",
- " bins=spectrum_frequency.value,\n",
+ " bins=spectrum_frequency,\n",
" )[0], \"erg / s\",)\n",
"emitted_luminosity_hist"
] |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
918545b
to
c994cfe
Compare
Seems the problem regarding HDF does not apply locally (at least on my machine) but in the pipelines. |
974fce4
to
d3d0dac
Compare
Pinning This PR is ready to merge. |
@epassaro