Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build after upgrading conda environment #1969

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

wkerzendorf
Copy link
Member

@wkerzendorf wkerzendorf requested a review from epassaro April 22, 2022 14:37
@tardis-bot

This comment was marked as off-topic.

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1969 (36b86ff) into master (b54dc86) will not change coverage.
The diff coverage is n/a.

❗ Current head 36b86ff differs from pull request most recent head d3d0dac. Consider uploading reports for the commit d3d0dac to get more accurate results

@@           Coverage Diff           @@
##           master    #1969   +/-   ##
=======================================
  Coverage   59.85%   59.85%           
=======================================
  Files          70       70           
  Lines        8080     8080           
=======================================
  Hits         4836     4836           
  Misses       3244     3244           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@epassaro
Copy link
Member

epassaro commented Apr 22, 2022

@wkerzendorf these two changes are enough to build docs locally:

diff --git a/docs/conf.py b/docs/conf.py
index 3e0a96be7..f8f33dd46 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -28,6 +28,7 @@
 import os
 import sys
 import datetime
+import tardis
 from importlib import import_module

 try:
diff --git a/docs/physics/spectrum/basic.ipynb b/docs/physics/spectrum/basic.ipynb
index 86f5e4bac..0a51ea926 100644
--- a/docs/physics/spectrum/basic.ipynb
+++ b/docs/physics/spectrum/basic.ipynb
@@ -358,7 +358,7 @@
    "source": [
     "emitted_luminosity_hist = u.Quantity(np.histogram(emitted_nus,\n",
     "                                                  weights=emitted_luminosities,\n",
-    "                                                  bins=spectrum_frequency.value,\n",
+    "                                                  bins=spectrum_frequency,\n",
     "                                                 )[0], \"erg / s\",)\n",
     "emitted_luminosity_hist"
    ]

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@epassaro epassaro force-pushed the docs/unit_import_problem branch from 918545b to c994cfe Compare April 24, 2022 18:56
@epassaro epassaro changed the title trying to fix the docs build in the new conda environment Fix docs build after upgrading conda environment Apr 24, 2022
@epassaro
Copy link
Member

Seems the problem regarding HDF does not apply locally (at least on my machine) but in the pipelines.

@epassaro epassaro force-pushed the docs/unit_import_problem branch from 974fce4 to d3d0dac Compare April 24, 2022 19:44
@epassaro
Copy link
Member

Pinning hdf5=1.10 solves the problem in the pipelines. I couldn't reproduce the problem in my machine.

This PR is ready to merge.

@epassaro epassaro requested a review from andrewfullard April 24, 2022 22:52
@andrewfullard andrewfullard merged commit 8afa38e into tardis-sn:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants