Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuum Opacities #1917

Merged
merged 10 commits into from
Mar 2, 2022
Merged

Continuum Opacities #1917

merged 10 commits into from
Mar 2, 2022

Conversation

Rodot-
Copy link
Contributor

@Rodot- Rodot- commented Feb 28, 2022

Fixed slowdown caused by previous merge of the continuum branch. Continuum processes can now be enabled.
WARNING: tests still required for running with continuum processes!
TODO: remove old plasma opacity calculators

Moved the continuum opacity calculations over to opacities.py

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@Rodot- Rodot- marked this pull request as draft February 28, 2022 21:54
@Rodot- Rodot- requested review from wkerzendorf and chvogl February 28, 2022 21:54
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #1917 (256b9d0) into master (c7649d8) will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1917      +/-   ##
==========================================
- Coverage   59.04%   58.76%   -0.28%     
==========================================
  Files          70       70              
  Lines        7767     7834      +67     
==========================================
+ Hits         4586     4604      +18     
- Misses       3181     3230      +49     
Impacted Files Coverage Δ
...is/tardis/montecarlo/montecarlo_numba/opacities.py 34.69% <0.00%> (-45.31%) ⬇️
.../montecarlo/montecarlo_numba/single_packet_loop.py 23.43% <0.00%> (-4.87%) ⬇️
tardis/tardis/montecarlo/montecarlo_numba/base.py 31.19% <0.00%> (-1.27%) ⬇️
...is/tardis/plasma/properties/continuum_processes.py 34.97% <0.00%> (-0.54%) ⬇️
...dis/montecarlo/montecarlo_numba/numba_interface.py 36.21% <0.00%> (-0.33%) ⬇️
...rdis/tardis/montecarlo/montecarlo_numba/vpacket.py 19.19% <0.00%> (-0.04%) ⬇️
...s/tardis/montecarlo/montecarlo_numba/macro_atom.py 51.61% <0.00%> (ø)
...dis/montecarlo/montecarlo_numba/formal_integral.py 51.36% <0.00%> (ø)
.../montecarlo/montecarlo_numba/r_packet_transport.py 16.66% <0.00%> (+0.21%) ⬆️
.../tardis/montecarlo/montecarlo_numba/interaction.py 20.00% <0.00%> (+0.95%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7649d8...256b9d0. Read the comment docs.

…he opacities.py file. Removed Continuum class and put relevant arrays into the numba plasma. Updated tests accordingly.

Co-authored-by: sonachitchyan chitchyan.sona@gmail.com
Co-authored-by: chvogl cvogl@mpa-garching.mpg.de
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Rodot- Rodot- requested a review from sonachitchyan March 2, 2022 20:40
@Rodot- Rodot- added bugfix 🪲 opacity Related to opacity extensions in TARDIS labels Mar 2, 2022
@Rodot- Rodot- marked this pull request as ready for review March 2, 2022 21:20
tardis/montecarlo/montecarlo_numba/base.py Outdated Show resolved Hide resolved
tardis/montecarlo/montecarlo_numba/base.py Outdated Show resolved Hide resolved
tardis/montecarlo/montecarlo_numba/base.py Outdated Show resolved Hide resolved
tardis/montecarlo/montecarlo_numba/base.py Outdated Show resolved Hide resolved
tardis/montecarlo/montecarlo_numba/r_packet_transport.py Outdated Show resolved Hide resolved
tardis/plasma/properties/continuum_processes.py Outdated Show resolved Hide resolved
@Rodot- Rodot- requested a review from andrewfullard March 2, 2022 21:44
@Rodot- Rodot- merged commit f4f26da into tardis-sn:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix 🪲 opacity Related to opacity extensions in TARDIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants