Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make update-refdata pipeline open a PR instead of merging changes #1900

Merged
merged 10 commits into from
Feb 22, 2022

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Feb 21, 2022

Description

Change in the update reference data. Now opens a PR in the tardis-refdata repository instead of pushing the changes.

Example: https://github.com/tardis-sn/tardis-refdata/pull/54/files

Motivation and context

For security purposes.

How has this been tested?

  • Testing pipeline.
  • Other.
  • [ ]
    By the pipeline itself.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro epassaro marked this pull request as draft February 21, 2022 20:16
@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1900 (f9f039f) into master (69b433c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1900   +/-   ##
=======================================
  Coverage   61.17%   61.17%           
=======================================
  Files          69       69           
  Lines        7331     7331           
=======================================
  Hits         4485     4485           
  Misses       2846     2846           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b433c...f9f039f. Read the comment docs.

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro epassaro force-pushed the open-pr-refdata branch 2 times, most recently from 5259669 to 2b9b8af Compare February 22, 2022 18:26
@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro epassaro force-pushed the open-pr-refdata branch 2 times, most recently from 5a55a00 to 99f373d Compare February 22, 2022 20:03
@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro
Copy link
Member Author

/azp run update-refdata

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@epassaro epassaro marked this pull request as ready for review February 22, 2022 20:50
@wkerzendorf wkerzendorf merged commit 059f959 into tardis-sn:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants