Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to append seed & index values only once for a particular RPacketTracker instance #1881

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

DhruvSondhi
Copy link
Contributor

@DhruvSondhi DhruvSondhi commented Jan 30, 2022

Description

Motivation and context

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@DhruvSondhi DhruvSondhi requested review from andrewfullard and wkerzendorf and removed request for andrewfullard January 30, 2022 07:05
@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@DhruvSondhi DhruvSondhi changed the title Changed to Append seed & index values only once for a particular RPacketTracker instance Changed to append seed & index values only once for a particular RPacketTracker instance Jan 30, 2022
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #1881 (73aaaf7) into master (583c739) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1881      +/-   ##
==========================================
+ Coverage   62.48%   62.55%   +0.07%     
==========================================
  Files          68       68              
  Lines        7135     7127       -8     
==========================================
  Hits         4458     4458              
+ Misses       2677     2669       -8     
Impacted Files Coverage Δ
...dis/montecarlo/montecarlo_numba/numba_interface.py 36.92% <0.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 583c739...73aaaf7. Read the comment docs.

@wkerzendorf
Copy link
Member

can you rebase?

@DhruvSondhi
Copy link
Contributor Author

This PR was made to be merged with the single_seed_index PR that was opened, #1879

@DhruvSondhi DhruvSondhi changed the base branch from single_seed_index to master January 30, 2022 08:40
@DhruvSondhi
Copy link
Contributor Author

Changed the base branch to master for this PR

Copy link
Member

@wkerzendorf wkerzendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side

@andrewfullard andrewfullard merged commit 60b76ef into tardis-sn:master Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants