Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed fstring issue from mixing quotes and reformatted files from fstring PR with black #1842

Merged
merged 4 commits into from
Dec 13, 2021

Conversation

Rodot-
Copy link
Contributor

@Rodot- Rodot- commented Dec 13, 2021

Fixed a bug in the docs build caused by a bad fstring in the widgets file. Also reformatted the files from the f-string PR with black as the PR broke the style.

Motivation and context

Docs coverage was failing

How has this been tested?

  • Testing pipeline.
  • Other.

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@tardis-bot
Copy link
Contributor

tardis-bot commented Dec 13, 2021

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@Rodot- Rodot- changed the title Fixed fstring issue from mixing quotes Fixed fstring issue from mixing quotes and reformatted files from fstring PR with black Dec 13, 2021
Copy link
Contributor

@afloers afloers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #1842 (3e92c02) into master (5927fa8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1842   +/-   ##
=======================================
  Coverage   57.65%   57.65%           
=======================================
  Files          66       66           
  Lines        6809     6809           
=======================================
  Hits         3926     3926           
  Misses       2883     2883           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5927fa8...3e92c02. Read the comment docs.

@andrewfullard andrewfullard merged commit fca2c8c into tardis-sn:master Dec 13, 2021
@Rodot- Rodot- deleted the fix_gui_bug branch December 13, 2021 15:57
DhruvSondhi pushed a commit to DhruvSondhi/tardis that referenced this pull request Dec 14, 2021
…ring PR with black (tardis-sn#1842)

* Fixed fstring issue from mixing quotes

* Fixed formatting with black

* updated with newer black version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants