-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to make docs build in parallel #1803
Conversation
Before a pull request is accepted, it must meet the following criteria:
|
2 similar comments
Before a pull request is accepted, it must meet the following criteria:
|
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1803 +/- ##
=======================================
Coverage 58.22% 58.22%
=======================================
Files 66 66
Lines 6722 6722
=======================================
Hits 3914 3914
Misses 2808 2808 Continue to review full report at Codecov.
|
Hi @smithis7, sorry for not reviewing this lately. I think
That variable could be called What do you think? @jaladh-singhal @wkerzendorf |
We can see what they think -- I feel like in general though, people building the documentation locally would like it to be built fast and are not as concerned about their cores for the 10-15 minutes that the build is occurring. If someone is really concerned about their cores, they are always able to type in the full sphinx command |
9f91fa0
to
3d1eb79
Compare
@smithis7 Can you post the result of runs with cores |
f5012cf
to
3755d75
Compare
@epassaro Two recent builds:
Additionally, this difference will become greater as we add more notebooks. |
I see, great work! I've implemented caching the conda env in |
Description
See https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-j
Now,
make html
allows aCORES
argument to let you build the documentation in parallel. In the GitHub pipelines, we useCORES=auto
which makes the documentation build with all available cores.Motivation and context
The documentation build is very slow.
How has this been tested?
Documentation built locally and on GitHub.
Examples
Compare https://github.com/tardis-sn/tardis/actions/runs/1381526801 with https://github.com/smithis7/tardis/actions/runs/1387845143.
See the note: https://smithis7.github.io/tardis/branch/speed_up_doc/development/documentation_guidelines.html
Type of change
Checklist