-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up docs build #1801
Cleaning up docs build #1801
Conversation
Before a pull request is accepted, it must meet the following criteria:
|
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.79%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Codecov Report
@@ Coverage Diff @@
## master #1801 +/- ##
=======================================
Coverage 58.25% 58.25%
=======================================
Files 66 66
Lines 6721 6721
=======================================
Hits 3915 3915
Misses 2806 2806 Continue to review full report at Codecov.
|
We do not format |
45f6f43
to
be50ea3
Compare
@epassaro sorry to make changes while you were reviewing. I had a docs failure so I just had to revert it back. I don't see the harm in doing the black formatting in this PR, I think it should be formatted correctly, and this seems as good of a PR as any to add that in, right? |
beffac8
to
9be1bdd
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smithis7 You've applied your organization skills excellently in code too - conf.py
now looks a lot neater. Thanks for this PR other changes like gitignoring were required too!
I just have one small comment and then it's ready to be merged (do ping me when you push it so that I don't forget).
5c67d58
to
19eb1e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @smithis7 - ready to merge!
Description
ZENODO.rst
by hooking into sphinx..gitignore
.conf.py
with black.Motivation and context
Makes sure TARDIS is following best practices. See the discussion on #1757 for more context.
How has this been tested?
Docs built locally and on github.
Examples
https://smithis7.github.io/tardis/branch/conf_format_doc/index.html
Type of change
Formatting.
Checklist