Changed the way specific_log_level flag works in the Logging Configuration
#1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before a pull request is accepted, it must meet the following criteria:
|
andrewfullard
requested changes
Aug 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
==========================================
+ Coverage 58.42% 58.45% +0.03%
==========================================
Files 66 66
Lines 6684 6687 +3
==========================================
+ Hits 3905 3909 +4
+ Misses 2779 2778 -1
Continue to review full report at Codecov.
|
28f377d to
79291e7
Compare
specific flag works in the Logging Configurationspecific_log_level flag works in the Logging Configuration
5e3d952 to
7dc8ed6
Compare
|
Can you write up the bug that this fixes into an issue so we know what is being fixed? |
7dc8ed6 to
21ad1a0
Compare
andrewfullard
approved these changes
Aug 16, 2021
21ad1a0 to
24c128e
Compare
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
…uration (tardis-sn#1769) * Changed the logical implementation for the `specific` flag in the debug schema for logging * Fixed the implementation with intended logic * Added logic change for specific_log_level flag * Changed check for specific_log_level parameter & setting it up via the YAML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation didn't cater to a bug that I have encountered recently. This PR aims to implement the functionality such that we are able to set the
specificflag default value in thedebugsub section of thetardis_config.yml.Description
Motivation and context
How has this been tested?
Type of change
Checklist