-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Quickstart Metadata #1727
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Before a pull request is accepted, it must meet the following criteria:
|
Codecov Report
@@ Coverage Diff @@
## master #1727 +/- ##
=======================================
Coverage 61.87% 61.87%
=======================================
Files 63 63
Lines 5852 5852
=======================================
Hits 3621 3621
Misses 2231 2231 Continue to review full report at Codecov.
|
* fix quickstart metadata * [build docs]
* fix quickstart metadata * [build docs]
Description
Makes it so quickstart notebook does not run when
DISABLE_NBSPHINX=1
.Motivation and context
Fixing a mistake I made when working with #1711
How has this been tested?
Examples
After running
DISABLE_NBSPHINX=1 make html
, I got:See built documentation: https://smithis7.github.io/tardis/branch/patch-1/quickstart/quickstart.html
Type of change
Checklist