Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Port tardis_opacities script from tardisanalysis" #1677

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Jun 29, 2021

Reverts #1580

This is intended to allow the addition of proper credit to the PR #1580

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #1677 (e561684) into master (c47a3df) will not change coverage.
The diff coverage is n/a.

❗ Current head e561684 differs from pull request most recent head dbcf9b2. Consider uploading reports for the commit dbcf9b2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1677   +/-   ##
=======================================
  Coverage   61.89%   61.89%           
=======================================
  Files          62       62           
  Lines        5732     5732           
=======================================
  Hits         3548     3548           
  Misses       2184     2184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c47a3df...dbcf9b2. Read the comment docs.

@tardis-bot
Copy link
Contributor

Before a pull request is accepted, it must meet the following criteria:

  • Is the necessary information provided?
  • Is this a duplicate PR?
    • If a new PR is clearly a duplicate, ask how this PR is different from the original PR?
    • If this PR is about to be merged, close the original PR with a link to this new PR that solved the issue.
  • Does it pass existing tests and are new tests provided if required?
    • The test coverage should not decrease, and for new features should be close to 100%.
  • Is the code tidy?
    • No unnecessary print lines or code comments.

@jaladh-singhal jaladh-singhal merged commit 719fedb into master Jul 1, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
@andrewfullard andrewfullard deleted the revert-1580-opacities branch July 20, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants