Fix macOS tests (pickle protocol 5) #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewfullard
approved these changes
Apr 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
==========================================
- Coverage 67.57% 67.57% -0.01%
==========================================
Files 68 68
Lines 6100 6103 +3
==========================================
+ Hits 4122 4124 +2
- Misses 1978 1979 +1
Continue to review full report at Codecov.
|
andrewfullard
approved these changes
Apr 13, 2021
2 tasks
This was referenced May 12, 2021
atharva-2001
pushed a commit
to atharva-2001/tardis
that referenced
this pull request
Oct 1, 2021
* try to force python>=3.8 * undo - try to force python>=3.8; install pickle5 * install pickle5 (via pip) * try to patch pickle version * blackify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pickle5backport viapiptardis/__init__.pyto force the use of the backportMotivation and Context
macOS tests failed recently due to the latest reference data update (tardis-sn/tardis-refdata#41). It was updated using a conda-solved Linux environment with
python3.8 which usespickleprotocol 5 by default (PEP 574). The macOS environment of TARDIS is tied topython3.7 becausepyneconda-forge package is not currently supported for this OS (pyne/pyne#1372), making it impossible to read files generated with the new protocol.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: