Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SEDec to SDEC in Spectral element DEComposition plot #1441

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

jaladh-singhal
Copy link
Member

@jaladh-singhal jaladh-singhal commented Jan 29, 2021

Changed all SEDec to SDEC in module name and code.

Motivation and Context

SEDec still includes SED that stands for Spectral Energy Distribution which may cause confusion to some users. Thus SDEC is a better choice.

How Has This Been Tested?

  • Testing pipeline
  • Reference Data Comparison following these instructions
  • Other (please describe)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • None of the above (please describe)

Checklist:

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have built the documentation on my fork following these instructions
  • I have assigned and requested two reviewers for this pull request

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1441 (1ea417d) into master (1053c90) will decrease coverage by 1.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
- Coverage   71.16%   70.03%   -1.14%     
==========================================
  Files          67       67              
  Lines        5521     5312     -209     
==========================================
- Hits         3929     3720     -209     
  Misses       1592     1592              
Impacted Files Coverage Δ
...dis/tardis/montecarlo/montecarlo_numba/r_packet.py 23.15% <0.00%> (-7.83%) ⬇️
.../tardis/montecarlo/montecarlo_numba/interaction.py 24.32% <0.00%> (-5.68%) ⬇️
.../montecarlo/montecarlo_numba/single_packet_loop.py 24.56% <0.00%> (-3.78%) ⬇️
...rdis/tardis/montecarlo/montecarlo_numba/vpacket.py 15.00% <0.00%> (-2.48%) ⬇️
tardis/tardis/plasma/properties/util/macro_atom.py 30.00% <0.00%> (-2.26%) ⬇️
...rdis/montecarlo/montecarlo_numba/tests/conftest.py 91.11% <0.00%> (-1.88%) ⬇️
tardis/tardis/plasma/properties/nlte.py 39.21% <0.00%> (-1.74%) ⬇️
...s/tardis/montecarlo/montecarlo_numba/macro_atom.py 43.75% <0.00%> (-1.71%) ⬇️
tardis/tardis/montecarlo/spectrum.py 70.00% <0.00%> (-1.70%) ⬇️
...is/tardis/plasma/properties/continuum_processes.py 41.66% <0.00%> (-1.58%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1053c90...130f904. Read the comment docs.

Copy link
Member

@jamesgillanders jamesgillanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - happy for it to be merged

@andrewfullard andrewfullard merged commit 4c346f0 into tardis-sn:master Jan 29, 2021
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
…n#1441)

* Renamed SEDec to SDEC throughout the module

* Changed module name and in init file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants