Fixed calculate_distance_line
showing nu_diff < 0
#1317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running
calculate_distance_line
, once in a while nu_diff would be computed as a negative number. In the C version, when computing the distance to a line, there is first a check to see if we're at the last line in the list. If we are, we return MISS_DISTANCE instead. The numba code had a check that returned MISS_DISTANCE but it checked if nu_line was 0 instead of checking if we were at the last line.How Has This Been Tested?
I've run an example tardis config with both the numba and C versions. The numba version no longer complains about negative nu_diff values and the spectra seem consistent between eachother.
Types of changes
Checklist: