Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sponsor button to TARDIS #1313

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Add Sponsor button to TARDIS #1313

merged 1 commit into from
Oct 5, 2020

Conversation

jaladh-singhal
Copy link
Member

GitHub allows repositories to show a Sponsor button on side panel to make it easier to find it. Adding FUNDING.yml to .github will do that.

The rendered button will look exactly same as how it looks at matplotlib and astropy which are also sponsored by NumFocus. Here's how it looks at matplotlib - see "sponsor this project" section:
image

Motivation and Context

Closes #1305

How Has This Been Tested?

This file is exactly same as that at matplotlib so it will work as expected. Also I have enabled sponsorship feature from tardis settings and saw the correct preview when creating this file.

@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #1313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1313   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files          46       46           
  Lines        3799     3799           
=======================================
  Hits         3099     3099           
  Misses        700      700           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1936855...80ce626. Read the comment docs.

@wkerzendorf wkerzendorf merged commit e0fce2e into master Oct 5, 2020
@jaladh-singhal jaladh-singhal deleted the sponsor-button branch October 5, 2020 17:59
atharva-2001 pushed a commit to atharva-2001/tardis that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumFOCUS Donation Link
2 participants