fix for issue #1228 #1236
Closed
fix for issue #1228 #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
==========================================
- Coverage 80.63% 80.57% -0.07%
==========================================
Files 41 41
Lines 3424 3428 +4
==========================================
+ Hits 2761 2762 +1
- Misses 663 666 +3
Continue to review full report at Codecov.
|
|
Up to here, all test passed locally |
|
Should I move the compare test to it's own file? |
|
This is ready to merge |
* Added roadmap link to main page * Added roadmap page Co-authored-by: Marc Williamson <marcwilliamson@Marcs-MacBook-Pro.local>
* Update team.rst - Add roles and descriptions Added roles and descriptions to the team page * Update team.rst - Added new GSoC students Update GSoC students section * Update team.rst - Added new roles Added new roles and minor style changes * add several nbsphinx related options * restructure the Governance model page * re-enabled nbsphinx * fix issues marked by @yssa Co-authored-by: Yssa Camacho <yssavo.camacho@gmail.com>
* Update team.rst - Add roles and descriptions Added roles and descriptions to the team page * Update team.rst - Added new GSoC students Update GSoC students section * Update team.rst - Added new roles Added new roles and minor style changes * add several nbsphinx related options * restructure the Governance model page * re-enabled nbsphinx * add adapted CoC * ammending code of conduct in the root * add code of conduct * getting upstream/master team.rst Co-authored-by: Yssa Camacho <yssavo.camacho@gmail.com>
* add code_of_conduct_symlink * add code of conduct link
* Added new contributing guidelines * Added symlink of Contributing.md to Contribting to TARDIS section * Fixed sym link * Update CONTRIBUTING.md Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@gmail.com> * Update CONTRIBUTING.md Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@gmail.com> Co-authored-by: Marc Williamson <marxwillia@gmail.com> Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Radial1DModel.from_csvy()so the dataframes are read appropriately, and that the first is removed only when it's being read from a csv table.Motivation and Context
See #1235 and #1228 for context
How Has This Been Tested?
pytestpasses for all test in the folder.xfailtests will be added in the next PR of the projectTypes of changes
Checklist: