-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move and rename coverage file #1218
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1218 +/- ##
==========================================
+ Coverage 77.71% 80.63% +2.91%
==========================================
Files 91 41 -50
Lines 5727 3423 -2304
==========================================
- Hits 4451 2760 -1691
+ Misses 1276 663 -613 Continue to review full report at Codecov.
|
I don't know so much about coverage. This is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just want to make sure you aren't missing an ending '*' in line 47?
@marxwillia thanks for the suggestion — done! |
How does the sunburst graph looks now? |
* Moved and renamed coverage file * Omit astropy_init from coverage calculation * generalize omit of astropy_init to all file types
Description
I've moved the coverage configuration file to the
TARDIS
root directory; this should ensure that it is read in correctly (e.g., correct files are omitted from coverage calculation).Motivation and Context
When running
python setup.py test --coverage
locally, I noticed that test files were being included in coverage counts. These are explicitly omitted in the coverage configuration file.How Has This Been Tested?
Checking the coverage page for this PR seems to indicate that it works as expected.
Screenshots (if appropriate):
The above image shows the coverage sunburst from our codecov page, which notably includes test folders that are excluded in the configuration file. By changing the location of the coverage file, this will (hopefully!) be fixed.
Types of changes
Checklist: