Minor changes to the environment file and cleanup #1203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
=======================================
Coverage 77.71% 77.71%
=======================================
Files 91 91
Lines 5727 5727
=======================================
Hits 4451 4451
Misses 1276 1276 Continue to review full report at Codecov.
|
| @@ -55,7 +53,6 @@ jobs: | |||
|
|
|||
| - bash: | | |||
| source activate tardis | |||
| conda install -y pytest-cov | |||
There was a problem hiding this comment.
pytest-cov is already installed in the environment.
| - docopt | ||
| - pytest-cov | ||
| - codecov |
There was a problem hiding this comment.
codecov package is not necessary to make Codecov work.
There was a problem hiding this comment.
Looks good to me!
I was actually wondering why we are installing pytest-cov when it's already in environment, when I was checking on failing pipeline. It's great you fixed it @epassaro 🎉
| - numba=0.43 | ||
| - numexpr | ||
| - Cython=0.29 |
There was a problem hiding this comment.
I'm not sure about this - if these packages are related somehow (I guess that's why there are newlines), we can add a comment at top to mention the purpose?
There was a problem hiding this comment.
I think that was the VSCode YAML extension/autoformatter.
74a8272 to
706a954
Compare
* Minor changes to the environment file * Remove old readthedocs files
Description
codecovdependency fromtardis_env.ymlsince is not required to make Codecov work.pytest-covline from test pipeline since it's already installed by the environment file.readthedocs.ymlfiles.Motivation and Context
Tidying up.
How Has This Been Tested?
Test and codecov report work.
Screenshots (if appropriate):
Types of changes
Checklist: