Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better icons for llama, Gemini, and other models, Issue-#675 #690

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

hpatel292-seneca
Copy link
Collaborator

In this PR, I’ve updated the logoUrl function in ChatCraftModel.ts to improve the icon selection for several new AI models, including Llama, Gemini, Mixtral, and Phi. I’ve added relevant icons for these models and ensured they display properly in the UI. The new icons were sourced and added to the assets folder, and now each model from providers like Meta, Google, and others has a unique, recognizable logo. This helps enhance the user interface by providing more visually distinct and accurate model representations.

@hpatel292-seneca hpatel292-seneca marked this pull request as ready for review October 2, 2024 18:23
@hpatel292-seneca hpatel292-seneca changed the title Use better icons for llama, Gemini, and other models, Issue-675 Use better icons for llama, Gemini, and other models, Issue-#675 Oct 2, 2024
@hpatel292-seneca
Copy link
Collaborator Author

image
image
image
image

@humphd
Copy link
Collaborator

humphd commented Oct 2, 2024

Lets reduce the size of these as much as you can. We're only going to show them in a very small width x height area, and also the quality can be reduced.

Use something like https://squoosh.app/ and make them all PNG.

@hpatel292-seneca
Copy link
Collaborator Author

I converted the jpg to png but the size of new logos is kind of same compare to other logos.
image

@humphd
Copy link
Collaborator

humphd commented Oct 2, 2024

Probably the existing ones need to get fixed too, but this looks reasonable.

@hpatel292-seneca
Copy link
Collaborator Author

I didn't push new changes. Let me do that first

@humphd
Copy link
Collaborator

humphd commented Oct 2, 2024

I was just going to ask... :)

@hpatel292-seneca
Copy link
Collaborator Author

I pushed new changes.

@humphd humphd added the hacktoberfest-accepted PRs done as part of Hacktoberfest label Oct 2, 2024
Copy link
Collaborator

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it. Thanks for doing this @hpatel292-seneca, it's appreciated.

@humphd humphd merged commit 6064b16 into tarasglek:main Oct 2, 2024
@humphd
Copy link
Collaborator

humphd commented Oct 2, 2024

Testing this in prod, looks good!

Screenshot 2024-10-02 at 3 36 42 PM

One thing I wonder about: should we change the llama check so it just looks for llama in the name? Otherwise only meta-llama comes up with an icon.

I'd be tempted to use it for all of them, since it's the same model.

@hpatel292-seneca
Copy link
Collaborator Author

I would love to update it. Should I?

@humphd
Copy link
Collaborator

humphd commented Oct 2, 2024

In a new PR? sure.

@hpatel292-seneca
Copy link
Collaborator Author

So could you please open new issue or should I send PR directly?

@humphd
Copy link
Collaborator

humphd commented Oct 2, 2024

Just send a PR, reference this issue (e.g., "Part of #690")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PRs done as part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants