Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: change console title and prompt #648

Merged
merged 1 commit into from
Oct 24, 2023
Merged

connect: change console title and prompt #648

merged 1 commit into from
Oct 24, 2023

Conversation

psergee
Copy link
Collaborator

@psergee psergee commented Oct 24, 2023

If a user specifies creds in connect string, use
cleaned up URI for console title and prompt.

$ tt connect admin:admin@localhost:3301
   • Connecting to the instance...
   • Connected to localhost:3301

localhost:3301>

$ tt connect localhost:3301
   • Connecting to the instance...
   • Connected to localhost:3301

localhost:3301>

@psergee
connect: change console title and prompt
3c59e9a 
If a user specifies creds in connect string, use
cleaned up URI for console title and prompt.
@psergee psergee requested a review from oleg-jukovec October 24, 2023 13:45
oleg-jukovec
oleg-jukovec approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@oleg-jukovec oleg-jukovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

@psergee psergee added the full-ci Enables full ci tests label Oct 24, 2023
@psergee psergee requested a review from LeonidVas October 24, 2023 13:57
@psergee psergee merged commit fab4c1a into master Oct 24, 2023
@psergee psergee deleted the psergee/no-gh-use-target-uri-for-cred-uris branch October 24, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonidVas LeonidVas LeonidVas approved these changes

@oleg-jukovec oleg-jukovec oleg-jukovec approved these changes

Assignees
No one assigned
Labels
full-ci Enables full ci tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psergee @oleg-jukovec @LeonidVas