-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add CRUD module support #263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, I like this start.
86a52f6
to
970d0eb
Compare
970d0eb
to
0915260
Compare
8019e08
to
7ecc243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the a lot of work done.
d8a3a5d
to
1d890bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates! I think we'll be ready to merge this one after we clear up _many
errors case
1af7a63
to
0f530c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates and sorry for the long process! Approved from my side
c86f41d
to
a78a791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please create an issue with missing functionality?
I think there should be at least:
1. Implement an ability to decode custom types via Result/ResultMany.
But maybe something else?
This patch provides crud [1] methods as request objects to support CRUD API. The following methods are supported: * `insert` * `insert_object` * `insert_many` * `insert_object_many` * `get` * `update` * `delete` * `replace` * `replace_object` * `replace_many` * `replace_object_many` * `upsert` * `upsert_object` * `upsert_many` * `upsert_object_many` * `select` * `min` * `max` * `truncate` * `len` * `storage_info` * `count` * `stats` * `unflatten_rows` 1. https://github.com/tarantool/crud Closes #108
a78a791
to
5543374
Compare
This patch provides crud methods as request objects to support CRUD API.
The following methods are supported:
insert
insert_object
insert_many
insert_object_many
get
update
delete
replace
replace_object
replace_many
replace_object_many
upsert
upsert_object
upsert_many
upsert_object_many
select
min
max
truncate
len
storage_info
count
stats
unflatten_rows
Example:
Closes #108