forked from fl00r/go-tarantool-1.6
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: support queue 1.2.0 #206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
requested review from
DifferentialOrange,
vr009 and
0x501D
and removed request for
vr009
August 16, 2022 09:03
0x501D
reviewed
Aug 17, 2022
0x501D
reviewed
Aug 17, 2022
Non-critical tests improvements for queue subpackage. It does not affect a logic of the tests: * A duplicate code that creates a queue is extracted into a separate function. * A duplicate code that drops a queue is extraced into a separate function. * `t.Errorf() + return` replaced by `t.Fatalf()`. * `err.Error()` replaced by just `err` in formatted messages.
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-177-add-queue-missing
branch
2 times, most recently
from
August 17, 2022 13:40
0f68f62
to
cfce2f1
Compare
0x501D
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's about master-replica?
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-177-add-queue-missing
branch
2 times, most recently
from
August 18, 2022 13:47
585ad28
to
2ea5f7c
Compare
The pull request is a part of the epic: |
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-177-add-queue-missing
branch
from
August 20, 2022 16:17
2ea5f7c
to
9c26543
Compare
DifferentialOrange
approved these changes
Aug 23, 2022
* bump queue package version to 1.2.0 [1] * add Task.Touch(): increases TTR and/or TTL for tasks [2] * add Queue.Cfg(): set queue settings [3] * add Queue.ReleaseAll(): releases all taken tasks [4] * add Queue.State(): returns a current queue state [5] * add Queue.Identify(): identifies a shared session [6] 1. https://github.com/tarantool/queue/releases/tag/1.2.0 2. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L562-L576 3. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L450-L463 4. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L698-L704 5. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L377-L391 6. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L465-L494 Closes #110 Closes #177
oleg-jukovec
force-pushed
the
oleg-jukovec/gh-177-add-queue-missing
branch
from
August 24, 2022 06:43
9c26543
to
c031562
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done? Why? What problem is being solved?
I didn't forget about (remove if it is not applicable):
Related issues:
Closes #110
Closes #177
At first it was 5 separate commits, but they are perfectly merged into 1 logically.