Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support queue 1.2.0 #206

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

oleg-jukovec
Copy link
Collaborator

@oleg-jukovec oleg-jukovec commented Aug 16, 2022

What has been done? Why? What problem is being solved?

  • bump queue package version to 1.2.0 [1]
  • add Task.Touch(): increases TTR and/or TTL for tasks [2]
  • add Queue.Cfg(): set queue settings [3]
  • add Queue.ReleaseAll(): releases all taken tasks [4]
  • add Queue.State(): returns a current queue state [5]
  • add Queue.Identify(): identifies a shared session [6]
  1. https://github.com/tarantool/queue/releases/tag/1.2.0
  2. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L562-L576
  3. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L450-L463
  4. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L698-L704
  5. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L377-L391
  6. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L465-L494

I didn't forget about (remove if it is not applicable):

Related issues:

Closes #110
Closes #177

At first it was 5 separate commits, but they are perfectly merged into 1 logically.

@oleg-jukovec oleg-jukovec requested review from DifferentialOrange, vr009 and 0x501D and removed request for vr009 August 16, 2022 09:03
queue/queue.go Outdated Show resolved Hide resolved
queue/queue.go Outdated Show resolved Hide resolved
Non-critical tests improvements for queue subpackage. It does not affect
a logic of the tests:

* A duplicate code that creates a queue is extracted into a separate
  function.
* A duplicate code that drops a queue is extraced into a separate
  function.
* `t.Errorf() + return` replaced by `t.Fatalf()`.
* `err.Error()` replaced by just `err` in formatted messages.
@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/gh-177-add-queue-missing branch 2 times, most recently from 0f68f62 to cfce2f1 Compare August 17, 2022 13:40
Copy link
Member

@0x501D 0x501D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@DifferentialOrange DifferentialOrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's about master-replica?

queue/queue_test.go Show resolved Hide resolved
queue/queue_test.go Outdated Show resolved Hide resolved
queue/queue_test.go Show resolved Hide resolved
@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/gh-177-add-queue-missing branch 2 times, most recently from 585ad28 to 2ea5f7c Compare August 18, 2022 13:47
@oleg-jukovec
Copy link
Collaborator Author

What's about master-replica?

The pull request is a part of the epic:

#179

@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/gh-177-add-queue-missing branch from 2ea5f7c to 9c26543 Compare August 20, 2022 16:17
* bump queue package version to 1.2.0 [1]
* add Task.Touch(): increases TTR and/or TTL for tasks [2]
* add Queue.Cfg(): set queue settings [3]
* add Queue.ReleaseAll(): releases all taken tasks [4]
* add Queue.State(): returns a current queue state [5]
* add Queue.Identify(): identifies a shared session [6]

1. https://github.com/tarantool/queue/releases/tag/1.2.0
2. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L562-L576
3. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L450-L463
4. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L698-L704
5. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L377-L391
6. https://github.com/tarantool/queue/blob/1.2.0/README.md?plain=1#L465-L494

Closes #110
Closes #177
@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/gh-177-add-queue-missing branch from 9c26543 to c031562 Compare August 24, 2022 06:43
@oleg-jukovec oleg-jukovec merged commit bda4442 into master Aug 24, 2022
@oleg-jukovec oleg-jukovec deleted the oleg-jukovec/gh-177-add-queue-missing branch August 24, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing and new queue methods Add support of shared sessions in queue
3 participants