Auto Eject Host down from pool connections. #272

BruAPAHE · 2023-03-13T09:29:57Z

Привет, извини, что на русском. Не подскажешь есть ли механизм убирания упавшего тарантула из пула коннектов. Не могу найти в библиотеке. Пакет connection_pool. Нашел Deactivated(conn *tarantool.Connection, role Role) error
но нет примеров как использовать.

The text was updated successfully, but these errors were encountered:

oleg-jukovec · 2023-03-13T09:36:35Z

Добрый день. Совсем убрать на данный момент нельзя.

При падении тарантула пул это должен определить с некоторой задержкой и убрать его из списка активных соединений. Но подключаться к этому хосту он по-прежнему будет пытаться. А после успешного подключения - слать запросы.

Можно с помощью Discovered мешать добавлению повторного подключения в список активных соединений, но звучит это как костыль с неясной мотивацией:

https://pkg.go.dev/github.com/tarantool/go-tarantool@v1.10.0/connection_pool#Connect
https://pkg.go.dev/github.com/tarantool/go-tarantool@v1.10.0/connection_pool#OptsPool
https://pkg.go.dev/github.com/tarantool/go-tarantool@v1.10.0/connection_pool#ConnectionHandler

BruAPAHE · 2023-03-13T11:28:32Z

@oleg-jukovec Почему то не работает чекер, поставил на 1 секунду. Запросы все равно летят в недоступный контейнер.

connect, err := connection_pool.Connect([]string{"0.0.0.0:3302", "0.0.0.0:3303"}, tnt.Opts{
User: "guest",
Timeout: 6 * time.Second,
Reconnect: 10 * time.Second,
})
if err != nil {
log.Fatalln(err)
}

for {
	var result any
	log.Println(connect.GetTyped("tester2", "primary", tnt.IntKey{I: 1}, &result, connection_pool.ANY))
	log.Println(result)
	time.Sleep(1 * time.Second)
}

2023/03/13 14:26:53
2023/03/13 14:26:53 [1 Roxette 1986]
2023/03/13 14:26:54 client connection is not ready (0x4000)
2023/03/13 14:26:54
2023/03/13 14:26:55
2023/03/13 14:26:55 [1 Roxette 1986]
2023/03/13 14:26:56 client connection is not ready (0x4000)
2023/03/13 14:26:56
2023/03/13 14:26:57
2023/03/13 14:26:57 [1 Roxette 1986]
2023/03/13 14:26:57 tarantool: reconnect (7/0) to 0.0.0.0:3302 failed: dial tcp 0.0.0.0:3302: connect: connection refused
2023/03/13 14:26:58 client connection is not ready (0x4000)
2023/03/13 14:26:58

oleg-jukovec · 2023-03-13T13:10:23Z

Попробуйте убрать из опций Reconnect: 10 * time.Second, если сработает то это бажок: видимо где-то неправильно обрабатываем состояние соединения в reconnect'е.

BruAPAHE · 2023-03-13T13:54:37Z

@oleg-jukovec помогло, спасибо!

BruAPAHE · 2023-03-13T13:54:47Z

close

oleg-jukovec · 2023-03-13T14:16:57Z

Нужно будет посмотреть проблему внимательней. Хоть и не критично, но неприятно.

The ConnectionPool didn't close a connection if it couldn't get the conenction a role on update state check. Closes #272

The ConnectionPool didn't close a connection if it couldn't get a role when checking the connection. Closes #272

Overview The release adds pagination support and wrappers for for the crud module. Breaking changes There are no breaking changes in the release. New features Support pagination (#246). A Makefile target to test with race detector (#218). Support CRUD API (#108). An ability to replace a base network connection to a Tarantool instance (#265). Bugfixes Several non-critical data race issues (#218). ConnectionPool does not properly handle disconnection with Opts.Reconnect set (#272).

Overview The release adds pagination support and wrappers for the crud module. Breaking changes There are no breaking changes in the release. New features Support pagination (#246). A Makefile target to test with race detector (#218). Support CRUD API (#108). An ability to replace a base network connection to a Tarantool instance (#265). Bugfixes Several non-critical data race issues (#218). ConnectionPool does not properly handle disconnection with Opts.Reconnect set (#272).

Overview The release adds pagination support and wrappers for the crud module. Breaking changes There are no breaking changes in the release. New features Support pagination (#246). A Makefile target to test with race detector (#218). Support CRUD API (#108). An ability to replace a base network connection to a Tarantool instance (#265). Bugfixes Several non-critical data race issues (#218). Build on Apple M1 with OpenSSL (#260). ConnectionPool does not properly handle disconnection with Opts.Reconnect set (#272).

Overview The release adds pagination support and wrappers for the crud module. Breaking changes There are no breaking changes in the release. New features Support pagination (#246). A Makefile target to test with race detector (#218). Support CRUD API (#108). An ability to replace a base network connection to a Tarantool instance (#265). Missed iterator constant (#285). Bugfixes Several non-critical data race issues (#218). Build on Apple M1 with OpenSSL (#260). ConnectionPool does not properly handle disconnection with Opts.Reconnect set (#272).

Overview The release adds pagination support and wrappers for the crud module. Breaking changes There are no breaking changes in the release. New features Support pagination (#246). A Makefile target to test with race detector (#218). Support CRUD API (#108). An ability to replace a base network connection to a Tarantool instance (#265). Missed iterator constant (#285). Bugfixes Several non-critical data race issues (#218). Build on Apple M1 with OpenSSL (#260). ConnectionPool does not properly handle disconnection with Opts.Reconnect set (#272). Watcher events loss with a small per-request timeout (#284). Connect() panics on concurrent schema update (#278). Wrong Ttr setup by Queue.Cfg() (#278). Flaky queue/Example_connectionPool (#278). Flaky queue/Example_simpleQueueCustomMsgPack (#277). Other queue module version bumped to 1.3.0 (#278).

oleg-jukovec added the question Further information is requested label Mar 13, 2023

oleg-jukovec added bug Something isn't working 1sp and removed question Further information is requested labels Mar 13, 2023

BruAPAHE closed this as completed Mar 13, 2023

oleg-jukovec reopened this Mar 13, 2023

oleg-jukovec added good first issue Good for newcomers teamE labels Mar 13, 2023

oleg-jukovec self-assigned this Mar 15, 2023

oleg-jukovec added a commit that referenced this issue Mar 15, 2023

pool: handle disconnection with Opts.Reconnect

83b0cd3

The ConnectionPool didn't close a connection if it couldn't get the conenction a role on update state check. Closes #272

oleg-jukovec added a commit that referenced this issue Mar 15, 2023

pool: handle disconnection with Opts.Reconnect

5715e7f

The ConnectionPool didn't close a connection if it couldn't get a role when checking the connection. Closes #272

oleg-jukovec mentioned this issue Mar 15, 2023

pool: handle disconnection with Opts.Reconnect #274

Merged

3 tasks

oleg-jukovec added a commit that referenced this issue Mar 15, 2023

pool: handle disconnection with Opts.Reconnect

5966c4b

The ConnectionPool didn't close a connection if it couldn't get a role when checking the connection. Closes #272

oleg-jukovec closed this as completed in 56fb5a3 Mar 24, 2023

oleg-jukovec mentioned this issue Mar 24, 2023

Release 1.11.0 #279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto Eject Host down from pool connections. #272

Auto Eject Host down from pool connections. #272

BruAPAHE commented Mar 13, 2023

oleg-jukovec commented Mar 13, 2023 •

edited

Loading

BruAPAHE commented Mar 13, 2023 •

edited

Loading

oleg-jukovec commented Mar 13, 2023 •

edited

Loading

BruAPAHE commented Mar 13, 2023

BruAPAHE commented Mar 13, 2023

oleg-jukovec commented Mar 13, 2023 •

edited

Loading

Auto Eject Host down from pool connections. #272

Auto Eject Host down from pool connections. #272

Comments

BruAPAHE commented Mar 13, 2023

oleg-jukovec commented Mar 13, 2023 • edited Loading

BruAPAHE commented Mar 13, 2023 • edited Loading

oleg-jukovec commented Mar 13, 2023 • edited Loading

BruAPAHE commented Mar 13, 2023

BruAPAHE commented Mar 13, 2023

oleg-jukovec commented Mar 13, 2023 • edited Loading

oleg-jukovec commented Mar 13, 2023 •

edited

Loading

BruAPAHE commented Mar 13, 2023 •

edited

Loading

oleg-jukovec commented Mar 13, 2023 •

edited

Loading

oleg-jukovec commented Mar 13, 2023 •

edited

Loading