Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved cmake build to build without to checkout "external/json" manually #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improved cmake build to build without to checkout "external/json" manually #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e14b27d
Improved cmake build to build without to checkout "external/json" man…
Bjoe Apr 20, 2021
4c486b6
Verfiy if cmake version is 3.11 or higher for FetchContent
Bjoe Apr 20, 2021
c11299d
cmake 3.14.4 or above is needed for FetchContent_MakeAvailable()
Bjoe Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 34 additions & 10 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,46 @@ target_include_directories(taocpp-config INTERFACE
# require C++17
target_compile_features(taocpp-config INTERFACE cxx_std_17)

option(TAOCPP_CONFIG_INSTALL "Generate the install target" ${TAOCPP_CONFIG_IS_MAIN_PROJECT})

# find a suitable taoJSON
set(TAOCPP_CONFIG_JSON_MIN_VERSION 1.0.0)
find_package(taocpp-json ${TAOCPP_CONFIG_JSON_MIN_VERSION} QUIET CONFIG)
if(NOT taocpp-json_FOUND)
# if a compatible version of taoJSON is not already installed, build and install it from the submodule directory
message(STATUS "Adding taoJSON as submodule from external/json")
set(TAOCPP_JSON_INSTALL_INCLUDE_DIR ${CMAKE_INSTALL_INCLUDEDIR} CACHE STRING "Override taoJSON include install directory")
set(TAOCPP_JSON_INSTALL_CMAKE_DIR ${CMAKE_INSTALL_DATAROOTDIR}/json/cmake CACHE STRING "Override taoJSON cmake install directory")
add_subdirectory(external/json)
if(EXISTS external/json/CMakeLists.txt)
# if a compatible version of taoJSON is not already installed, build and install it from the submodule directory
message(STATUS "Adding taoJSON as submodule from external/json")
set(TAOCPP_JSON_INSTALL_INCLUDE_DIR ${CMAKE_INSTALL_INCLUDEDIR} CACHE STRING "Override taoJSON include install directory")
set(TAOCPP_JSON_INSTALL_CMAKE_DIR ${CMAKE_INSTALL_DATAROOTDIR}/json/cmake CACHE STRING "Override taoJSON cmake install directory")
add_subdirectory(external/json)
else()
if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.14.4)
include(FetchContent)
FetchContent_Declare(
taocpp-json
GIT_REPOSITORY https://github.com/taocpp/json.git
GIT_TAG master
)
FetchContent_MakeAvailable(taocpp-json)
else()
message(FATAL_ERROR "taoJSON headers are not found!\nInstall taoJSON OR\ncheckout the taoJSON project manually into external/json OR\nuse cmake 3.11 or above")
endif()
endif()
if(TAOCPP_CONFIG_INSTALL)
# install and export target
install(TARGETS taocpp-config taocpp-json EXPORT ${PROJECT_NAME}-targets)
endif()
# add taoJSON as a dependency
target_link_libraries(taocpp-config INTERFACE taocpp::json)
else()
if(TAOCPP_CONFIG_INSTALL)
# install and export target
install(TARGETS taocpp-config EXPORT ${PROJECT_NAME}-targets)
endif()
# add taoJSON as a dependency
target_link_libraries(taocpp-config INTERFACE taocpp::taocpp-json)
endif()

# add taoJSON as a dependency
target_link_libraries(taocpp-config INTERFACE taocpp::json)

# testing
option(TAOCPP_CONFIG_BUILD_TESTS "Build test programs" ${TAOCPP_CONFIG_IS_MAIN_PROJECT})
Expand All @@ -51,7 +78,6 @@ if(TAOCPP_CONFIG_BUILD_EXAMPLES)
add_subdirectory(src/example/config)
endif()

option(TAOCPP_CONFIG_INSTALL "Generate the install target" ${TAOCPP_CONFIG_IS_MAIN_PROJECT})
if(TAOCPP_CONFIG_INSTALL)
include(CMakePackageConfigHelpers)

Expand All @@ -68,8 +94,6 @@ if(TAOCPP_CONFIG_INSTALL)
# Enable version checks in find_package
write_basic_package_version_file(${PROJECT_NAME}-config-version.cmake COMPATIBILITY SameMajorVersion)

# install and export target
install(TARGETS taocpp-config taocpp-json EXPORT ${PROJECT_NAME}-targets)
install(FILES
${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}-config.cmake
${CMAKE_CURRENT_BINARY_DIR}/${PROJECT_NAME}-config-version.cmake
Expand Down