New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<ciso646> is removed in C++20 and should not be included #319

Closed

matbech opened this issue Jul 12, 2022 · 1 comment

Labels

bug

matbech commented Jul 12, 2022 •

edited

Loading

VS 17.3 Preview 4 fails to compile PEGTL with C++20 or higher:
Error:

C:\Program Files\Microsoft Visual Studio\2022\Preview\VC\Tools\MSVC\14.33.31627\include\ciso646(15,22): error C4996: '_Header_ciso646': warning STL4036: <ciso646> is removed in C++20. You can define _SILENCE_CXX20_CISO646_REMOVED_WARNING or _SILENCE_ALL_CXX20_DEPRECATION_WARNINGS to acknowledge that you have received this warning.

ciso646 should not be included in demangle.hpp:
https://github.com/taocpp/PEGTL/blob/main/include/tao/pegtl/demangle.hpp#L8
The <version> header should be used instead on C++20

The text was updated successfully, but these errors were encountered:

ColinH added the bug label

Member

ColinH commented Jul 13, 2022

Looking at demangle.hpp I'd say this header is probably not needed (anymore), I'll remove it and see whether all CI jobs agree.

ColinH closed this as completed in

40ca73f

ColinH added a commit that referenced this issue


          Fix #319 here, too.

dde838e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment