Fix/linker options #97
Conversation
This makes to sense. "-h FOO" is used to change the SONAME. It comes right before "--strip-all". So the SONAME will be set to "--strip-all". This will again re-enable unconditional stripping of the _tango.so file. (This came up as an SONAME called "--strip-all" will cause problems with tools that create rpm packages.)
the previous patch caused unconditional stripping by the linker to get re-enabled (in current git master, the build produces non-stripped libs) I haven't studied the whole setup.py, but in general the build process should output non-stripped libraries. Otherwise tools to create packages (rpm, dep) would have no access to the debug symbols and could not package them.
|
Thanks for your contribution! I'm curious though, what kind of problem did you encounter while building RPMs? At MAX-IV, we're using fpm and rpkg and they both work for packaging pytango. @tiagocoutinho What was the purpose of those flags originally? |
|
These flags were a futile attempt to reduce the library size. |
|
OK thanks! |
|
The RPMs are created using bitbake/yocto (a crosscompiling framework to create e.g. firmware for ARM). The RPMs are actually just an intermediary step used by bitbake before creating a flashable image. It might very well be that bitbake is using RPM slightly differently than e.g. rpkg. [Sorry for responding so late, I seem to have missed your message back then.] |
The setup.py adds an intended linker option which can cause problems later when trying to package the library. Please see commit messages for further details