This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
WIP: Fix read/write/is_allowed not called for dynamic attribute in async mode server #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests would pass in `GreenMode.Asyncio` if the read, write and is_allowed methods are not coroutines. This does not verify the problem reported: specifically, that dynamic attributes with async coroutines do not work properly. With these changes, the tests now fail as expected for `GreenMode.Asyncio`. The creation of the dynamic attributes was changed to use the more convenient `attribute` class instead of `Attr`. This also allows all data types to be more easily tested. The `initialize_dynamic_attributes` method is a built-in PyTango feature, called during device class instantiation, by the `DeviceClass` device factory. It is called after `__init__` and `init_device`, but before the device is exported. Also moved the test closer to the other dynamic attribute tests.
5841fd4 to
b455473
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with fix for #173.
Currently it is a draft with (failing) tests only. This PR is to continue the work started by @stanislaw55 in PR #337, rebased onto
develop. I cannot push changes to the forked repo.