This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Add omni_thread::ensure_self to AutoPythonAllowThreads #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix issues with multi-threaded applications, when using "standard" threads, i.e. not omnithreads. Typical failures occur when using `DeviceProxy` objects created in different threads that subscribe to events. The cppTango layer assumes threads are omnithreads, and some of its checks rely on them having an omnithread ID. This `ensure_self` object creates a dummy ID. The `AutoPythonAllowThreads` class is a guard used to release the GIL and protects all (most?) network I/O via the cppTango layer. An `ensure_self` object will now exist for the lifetime of each guard as well.
AntoineDupre
approved these changes
Nov 29, 2019
|
This is just to let you know that I'm testing this PR as well as solution proposed by Michal in #292. Soon I will post more information. |
|
Closing this in favour of #327 - that is a safer solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix issues with multi-threaded applications, when using "standard" threads, i.e. not omnithreads. Typical failures occur when using
DeviceProxyobjects created in different threads that subscribe to events.The cppTango layer assumes threads are omnithreads, and some of its checks rely on them having an omnithread ID. This
ensure_selfobject creates a dummy ID.The
AutoPythonAllowThreadsclass is a guard used to release the GIL and protects all (most?) network I/O via the cppTango layer. Anensure_selfobject will now exist for the lifetime of each guard as well.Closes issue #307
Closes issue #292
(Does not help with issue #315)